Add Cargo.lock and upgrade dependencies.#2423
Merged
xStrom merged 2 commits intolinebender:masterfrom Dec 14, 2025
Merged
Conversation
jneem
approved these changes
Dec 14, 2025
| [dependencies] | ||
| druid = { path="../.." } | ||
|
|
||
| wasm-bindgen = "0.2.95" |
Member
There was a problem hiding this comment.
Maybe it's worth pinning this and also the version of the wasm-bindgen cli in CI? The versions have to match exactly, which has caused me some pain in other projects.
Member
Author
There was a problem hiding this comment.
I know we've historically had some issues around this, but not for some years now. We use wasm-pack in CI which theoretically should install the exact correct version. Seems to have worked fine lately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modern Linebender standard is to include
Cargo.lockin the repo and this repository in specific would greatly benefit as it would keep a record of a working state as maintenance is non-existent.All the dependency bumps are SemVer compatible and match what the CI was already using.
Also pinned the mdBook CI version to match what the actual deployment script uses.