arc: implement ParamCurve - #378
Merged
waywardmonkeys merged 1 commit intoMar 16, 2026
Merged
Conversation
raphlinus
reviewed
Sep 21, 2024
waywardmonkeys
force-pushed
the
param-curve-and-arclen-for-arc
branch
from
December 7, 2024 11:30
060d631 to
e0a54eb
Compare
tomcur
reviewed
Dec 8, 2024
waywardmonkeys
force-pushed
the
param-curve-and-arclen-for-arc
branch
2 times, most recently
from
March 16, 2026 04:30
2e62c35 to
0101de3
Compare
waywardmonkeys
changed the title
ParamCurve, ParamCurveArclen for Arc
tomcur
reviewed
Mar 16, 2026
tomcur
left a comment
tomcur
left a comment
Member
There was a problem hiding this comment.
This looks good. Some clean up nits inline.
Implement `ParamCurve` for `Arc` and update `path_elements` to start from `Arc::start()`. Add regression tests covering endpoint and midpoint evaluation, rotated ellipses, reversed arcs, negative sweeps, and tiny sweeps.
waywardmonkeys
force-pushed
the
param-curve-and-arclen-for-arc
branch
from
March 16, 2026 12:47
0101de3 to
8bd623a
Compare
waywardmonkeys
changed the title
tomcur
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
ParamCurveforArcand updatepath_elementsto startfrom
Arc::start().Add regression tests covering endpoint and midpoint evaluation,
rotated ellipses, reversed arcs, negative sweeps, and tiny sweeps.