Skip to content

test: 馃拲 add failing offset test - #380

Open
richard-uk1 wants to merge 1 commit into
mainfrom
add_failing_offset_test
Open

test: 馃拲 add failing offset test#380
richard-uk1 wants to merge 1 commit into
mainfrom
add_failing_offset_test

Conversation

@richard-uk1

@richard-uk1 richard-uk1 commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

This patch doesn't have a fix, but it records the problem.

Changing to fit_to_bezpath (without the _opt) results in no error.

Run cargo test -- --ignored to see the failure.

This patch doesn't (yet) have a fix, but it records the problem.
@richard-uk1
richard-uk1 force-pushed the add_failing_offset_test branch from c1a4b96 to 465e392 Compare September 26, 2024 10:38
@mlwilkerson

Copy link
Copy Markdown
Contributor

I think the problem identified by this is the same as the one I reported in #602. Claude helped investigate and found that the curve in this PR no longer manifests the bug, since CubicOffset was removed in #489 and offsetting rewritten.

But I think #602 has a repro that still does reproduce the same underlying defect that this PR's test case previously reproduced and it might be that both #588 and #600 fix that remaining defect.

So this PR is probably stale and could be closed. Or, it might be worth keeping its test case as a regression test against what it previously failed on. However, Claude noted that the test's name suggests that infinite recursion is the root cause, but actually:

The stack is finite; the ITP bracket simply stops moving once scaled_epsilon wraps, and the uncapped while b - a >
2.0 * epsilon loop spins forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants