Add Green’s theorem moments derived from fontTools - #452
Merged
Conversation
jneem
reviewed
Jun 30, 2025
jneem
reviewed
Jun 30, 2025
jneem
reviewed
Jul 1, 2025
jneem
left a comment
jneem
left a comment
Member
There was a problem hiding this comment.
Looks fine to me. I'm a little reluctant to unilaterally approve new APIs, so let me bring it up at office hours this week (unless someone else wants to approve before that)
Member
|
This was discussed and approved in office hours, but @raphlinus noticed a typo he wanted to fix... |
raphlinus
approved these changes
Jul 7, 2025
raphlinus
left a comment
raphlinus
left a comment
Contributor
There was a problem hiding this comment.
Looks good modulo the comment typos. This is useful functionality and I think the API additions are not very intrusive. Thanks!
jneem
approved these changes
Jul 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #443.