Add BezPath.current_position() - #462
Merged
Merged
Conversation
jneem
reviewed
Jul 7, 2025
Contributor
Author
|
I did all changes, improved docs and renamed to |
jneem
reviewed
Jul 7, 2025
jneem
approved these changes
Jul 7, 2025
jneem
left a comment
jneem
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks fine to me now. Just a nitpick about the doc comment.
I think I actually liked the old name better, as "current" to me suggests state that is being modified over time. But this doesn't need to be blocked on naming.
Contributor
Author
|
Let's wait for another opinions. For reference canvas spec uses |
Contributor
Author
|
If there will be no opposition I will land this as-is on Thursday. |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Co-authored-by: jneem <joeneeman@gmail.com>
Contributor
Author
|
rebased! |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is useful to obtain current position (sometimes also called last point/current point) of path. That's the one that also takes ClosePath into account. Implementation is very similar to
PathEl.end_point, except that it handles close path.