Remove a bunch of deprecated utility functions/aliases - #487
Merged
Conversation
The main potentially controversial thing here is changes to the `Shape` trait But it's only removing items which already had default impls
DJMcNab
changed the title
Merged
tomcur
approved these changes
Aug 21, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
This was deprecated in #427 This PR is easily the most dubious of the three (#488, #487), because the functionality: - is expected to be publicly exposed ("as we probably want to iterate on the exact interface") - Doesn't have a neat replacement. This will likely need Raph's sign-off --------- Co-authored-by: Joe Neeman <joeneeman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main potentially controversial thing here is changes to the
Shapetrait But it's only removing items which already had default implsI'm not fully involved with Kurbo development, so this is done semi-blindly.