Use ICU4X built-in data #482
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data that is currently being generated in
parley_datais the same data that ICU4X ships with. However, usingtry_new_unstableconstructors with custom data providers can be less efficient than enabling thecompiled_datafeature, as these constructors do runtime lookups and branching, whereas mostcompiled_dataconstructors areconst.This requires unicode-org/icu4x#7268.
Benchmarks look neutral: