Make append_atom_to_line private - #736
Merged
Merged
Conversation
tomcur
commented
Aug 6, 2026
| Shaped clusters that cross grapheme boundaries are represented using the existing `Cluster::is_ligature_start` and `Cluster::is_ligature_continuation`; note these methods previously encoded graphemes as well. | ||
| Shaped clusters' advances are split evenly over the grapheme clusters they overlap. | ||
| `Run::cluster_range` now returns grapheme cluster indices relative to the run's shaped run. | ||
| `BreakerState::append_cluster_to_line` was replaced by `BreakerState::append_atom_to_line`. |
Member
Author
nicoburns
approved these changes
Aug 6, 2026
nicoburns
left a comment
nicoburns
left a comment
Collaborator
There was a problem hiding this comment.
I'm not using append_cluster_to_line, but Blitz is using BreakerState::append_inline_box_to_line. Hopefully that's still available.
Member
Author
Yep! |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 6, 2026
Member
|
It failed due to GitHub's incident today, but I realise that you should probably merge it even still Tom - I don't have a need to get this in that couple of hours later, and I haven't actually reviewed it myself, although I'm sure it's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can't usefully be called externally. The user has nothing they could pass to this method.