Select fonts by requested emoji presentation - #745
Open
kane50613 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Claude fact check + generates, Codex review.
Now font selection only checks for "who has the first char?". Variation selectors like
U+FE0Fare ignored, same forU+FE0E. It also happened in the downstream kane50613/takumi#1218.Per candidate font, an exact cmap format 14 match for the whole sequence wins first. Otherwise
U+FE0Fprefers fonts with color tables andU+FE0Efonts without. When no font matches the requested presentation, the base character still renders from a mismatched font instead of tofu.To check whether the font has color tables, I've mirrored ColorTableLookup from Blink.
#692 seems to be solving the same bug, but only by moving the emoji generic family to the front, which overrides user-selected fonts that have their own emoji glyphs. Checking each font's capability avoids that.
#620 is the segmentation layer above this and complementary.
Changelog
fontique::Charmap::map_variant, withMapVariantre-exported fromread-fonts.FontInfo::has_color_tables().QueryFont.has_color_tables.QueryFontstruct literals must provide the newhas_color_tablesfield.