Correct rounding of alpha. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the behavior match the other values in how they're rounded as well as the WPT.
waywardmonkeys
force-pushed
the
correctly-round-alpha
branch
from
a5d37bc to
7ada582
Compare
Collaborator
Author
|
This is one of the things that I found while comparing color test results between what's in svgtypes now and what's in the |
Collaborator
Author
|
@erxclau This is related / similar to some of your recent changes, so it might be of interest. |
Contributor
|
Thanks for sharing @waywardmonkeys! Makes sense that alpha should also mirror the RGB rounding. |
tomcur
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior match the other values in how they're rounded as well as the WPT.