Support no_std
#39
Support no_std
#39
Conversation
|
For this to work, we'd need a semver bump for I'm also not sure how generally useful this feature would be, so feedback is welcome. |
waywardmonkeys
force-pushed
the
support-no_std
branch
2 times, most recently
from
0688cd2 to
5efb018
Compare
tomcur
left a comment
tomcur
left a comment
There was a problem hiding this comment.
Perhaps this is important for someone. The only real downside is the big jump in MSRV and the semver bump, so perhaps it should just be delayed until color is ready to go in as well, allowing one more patch release just prior.
|
Yeah, I am inclined to do a 0.15.3 with roughly the current state of |
waywardmonkeys
force-pushed
the
support-no_std
branch
from
5efb018 to
afb19df
Compare
waywardmonkeys
force-pushed
the
support-no_std
branch
from
afb19df to
2c630c2
Compare
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
One possible tweak with how no_std is set, but otherwise looks good.
| # The MSRV jobs run only cargo check because different clippy versions can disagree on goals and | ||
| # running tests introduces dev dependencies which may require a higher MSRV than the bare package. | ||
| # | ||
| # For no_std checks we target x86_64-unknown-none, because this target doesn't support std |
There was a problem hiding this comment.
(there are reasonable arguments to use wasm32v1-none at some point, but not for this PR - IIRC, it was only stabilised in 1.84. Cc @xStrom)
This increases the MSRV to 1.81 for `core::error`.
waywardmonkeys
force-pushed
the
support-no_std
branch
from
2c630c2 to
79ee803
Compare
Signed-off-by: Nico Burns <[email protected]>
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Looks like it's mostly s/std/core/ and s/std/alloc. And we already have sufficient MSRV now.
4 participants
No description provided.