Skip to content

Conversation

@waywardmonkeys
Copy link
Collaborator

No description provided.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is probably sufficiently non-breaking.

Would it be worth the effort to run resvg's test suite with this version, to validate that the changes don't cause issues? I'm worried that some of the rounding changes could cause issues, although I think that would realistically only impact tests rather than actual users.

@waywardmonkeys
Copy link
Collaborator Author

Good call.

These break, but I think they're all unimportant, so once this releases, I'll fix things there:

failures:
    render::filters_feDropShadow_hsla_color
    render::filters_feSpecularLighting_lighting_color_eq_hsla
    render::filters_flood_color_hsla_color
    render::paint_servers_linearGradient_hsla_color
    render::paint_servers_radialGradient_hsla_color
    render::paint_servers_stop_hsla_color
    render::painting_fill_hsl_with_alpha
    render::painting_fill_hsla_with_percentage_s_and_l_values
    render::painting_fill_rgb_0_127_0_0_5
    render::painting_fill_rgba_0_127_0_0_5

Co-authored-by: Tom Churchman <[email protected]>
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Jan 20, 2025
Merged via the queue into linebender:main with commit 537dd52 Jan 20, 2025
15 checks passed
@waywardmonkeys waywardmonkeys deleted the release-0.15.3 branch January 20, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants