classic: implement dashed stroke clipping #1342
Open
+114
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
commented
Jan 5, 2026
Comment on lines
+421
to
+424
| #[cfg(feature = "bump_estimate")] | ||
| self.estimator | ||
| .count_path(shape.path_elements(SHAPE_TOLERANCE), &t, Some(style)); | ||
| self.encoding.encode_shape(shape, false) |
Member
Author
There was a problem hiding this comment.
I didn't want to tackle (or think about) tolerances here, and this is just lifted directly from the code in main, but I'm not entirely sure this is correct... The Estimator::count_path call gets SHAPE_TOLERANCE passed in (with a value of 0.01), but the Encoding::encode_shape call has a hard-coded 0.1 tolerance.
Additionally, as the note about tolerances in Scene::stroke says, this does nothing for handling tolerance under scaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #1332, implementing dashed stroke clipping as well.
The first commit here does just that (plus rejigging some of the control flow), the second factors out stroking logic shared with
Scene::stroketo a new private method.