Add font embolden #823
Open
Add font embolden #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmoulton
force-pushed
the
push-nwztnvrqyyux
branch
from
f317cd7 to
d4eddc4
Compare
|
Need to investigate:
|
jrmoulton
force-pushed
the
push-nwztnvrqyyux
branch
5 times, most recently
from
cef09c7 to
3e7d17e
Compare
switch to gpu embolden
jrmoulton
force-pushed
the
push-nwztnvrqyyux
branch
from
3e7d17e to
420d99d
Compare
|
This is now working. It has path expansion/stem darkening working on the GPU and properly works with Bevel, Miter, and Round joins. These are all configurable. The changes are implemented in both the cpu and gpu flatten shader. |
|
A quick update, this was discussed in Renderer office hours, also see transcript of the discussion. This would be great to have in some form, but the big question is review bandwidth as it's a fairly major change and has a risk of breaking things. We haven't forgotten about it, but need to decide what to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a direct port of the swash implementation of font embolden.It does seem to have about twice the "strength" of the swash implementation though and I haven't been able to figure out why.