Remove the SDL2 example #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @TheNachoBIT |
|
Oh, I have to solve this problem for something else. What happened is that cmake 4.0 came out and is now in use and it removes support for things that need older versions of cmake, which is a whole bunch of projects using cmake since they don't express a high enough minimum version. I'll take a quick look around to see what the fix is. |
|
Easier to just replace SDL2 with SDL3! See PR #887. |
If someone cares to work out why it doesn't compile and bring it back then they can do. But I don't, and we need CI to be working.
|
The interim plan is to land this as-is (i.e. only removing it from the workspace), then land #887 at our leisure. |
taj-p
added a commit
to taj-p/vello
that referenced
this pull request
Apr 3, 2025
Don't expose Skrifa public API + use norm coords slice Hardcode NonZero fill text rendering Add disclaimer to layout_glyphs Disable hinting for rotated, skewed text Prevent allocating a new path for each glyph Set no features on bytemuck clippy Add test for scaled glyphs Improve doco Use unscaled outlines . Parley example . more clippy Minor Make GlypRun members private Use &str Move bytemuck::cast_slice Update Parley deps Remove roboto Add unit tests for tiling (linebender#881) It would be nice to also add some tests for how it behaves at tile boundaries, but since at least from my experiments we do not seem to produce ideal results for those cases (yet?), I've left them out for now. Remove the SDL2 example (linebender#886) If someone cares to work out why it doesn't compile and then brings it back, then they can do. But I don't care to, and we need CI to be working. Use Wasm for text example . . . . . .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone cares to work out why it doesn't compile and then brings it back, then they can do.
But I don't care to, and we need CI to be working.