fix(with_winit): enable wgpu backends so web demo loads - #81
Open
matthargett wants to merge 1 commit into
Open
Conversation
The workspace pulls in `vello` with `default-features = false` (since `vello_svg` itself doesn't need `wgpu`), which drops vello's `wgpu_default` feature. The `with_winit` example only enabled vello's bare `wgpu` feature, so `wgpu` was compiled with no backends and `wgpu::Instance::new` panicked at startup with "No wgpu backend feature that is implemented for the target platform was enabled." — producing a blank page in every browser. Enable `wgpu_default` for the `with_winit` example on all targets so the `webgpu` backend (and native backends) are compiled in. Fixes linebender#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_winitweb demo has been crashing on startup in every browser (Firefox, Chrome, Safari) withRuntimeError: unreachableinsidewgpu::Instance::new, leaving a blank page.vello = { ..., default-features = false }(sincevello_svgitself doesn't needwgpu), which drops vello'swgpu_defaultfeature. Thewith_winitexample only re-enabled vello's barewgpufeature, sowgpuwas compiled with no backends — and on wasm32 itsInstance::newpanics with "No wgpu backend feature that is implemented for the target platform was enabled."wgpu_defaultfeature (instead ofwgpu) for thewith_winitexample on all targets, so thewebgpubackend (and the native backends) are actually compiled in.Verified locally with
cargo build -p with_winit --bin with_winit_bin --target wasm32-unknown-unknown.cargo tree -p wgpu --target wasm32-unknown-unknownnow showswgpufeatures includewebgpu, where previously none of the backend features were enabled.Fixes #80
Test plan