Remove screenshot tolerance from tests - #1839
Open
Una539 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR! This looks good at first glance, but I'm leaving for vacation today, so I won't have time to review this. Ping me in a week if I haven't followed up on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove screenshot tolerance from screenshot tests and use exact pixel comparison.
Fixes #1759
Motivation
After switching to vello_cpu, screenshot tests appear deterministic enough on my machine to remove the tolerance parameter.
I tested locally by setting tolerance to 0. Existing screenshots were regenerated using:
MASONRY_TEST_BLESS=1 cargo test -p masonry
After regeneration, running the test suite twice with zero tolerance passed.
Changes