fix(masonry/virtual_scroll): Fix unintended regression from #1796 - #1841
Open
zheylmun wants to merge 1 commit into
Open
fix(masonry/virtual_scroll): Fix unintended regression from #1796#1841zheylmun wants to merge 1 commit into
zheylmun wants to merge 1 commit into
Conversation
…r#1796 Laying out stashed children is an error. Re-add the guard for virtual_scroll to prevent panic.
Collaborator
|
At a glance, I'm a bit confused why stashing the children is necessary at all. "A child scrolled out of view" is explicitly what stashing is not for. (This kind of complication is why I'm considering removing VirtualScroll.) |
Author
|
Trying to lay out the children that aren't mounted causes a panic at the moment. I agree this approach a clunky fix, but it's restoring the behavior that was removed at the beginning of July. I'm not familiar enough with the guts to really weigh in on the "right" fix. I simply tracked down the regression. Happy enough to keep this on a fork if you are considering a more permanent solution. |
Collaborator
|
Fair enough. Will review this in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laying out stashed children is an error.
Re-add the guard for stashed children in virtual_scroll::layout to prevent panic.