Update to Parley 2025-03-25. #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
May 1, 2025
| accesskit = "0.17.0" | ||
| accesskit_winit = "0.23.0" | ||
| accesskit = "0.18.0" | ||
| accesskit_winit = "0.24.0" |
There was a problem hiding this comment.
This update means that we no longer support NativeActivity, an unfortunate regression. We panic at this code.
https://github.com/AccessKit/accesskit/blob/10f4bd1344b98ebb2baf969e62afdd767f5ff1d1/platforms/winit/src/platform_impl/android.rs#L31-L39. It looks like the non-support for NativeActivity is intentional here.
cc @mwcampbell what do you suggest doing in this case? Is there a no-op AccessKit winit backend we can use, or is the only solution to conditionally compile out the accessibility support on Android if we want to support Native Activity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #936 stalling but Matt wanting AccessKit changes I decided to split out parts of #936 into this PR. This brings in Parley from March 25th, 2025 and that gets us the AccessKit update.