Recompute new state if board is modified#33
Merged
Conversation
deuszx
reviewed
Sep 17, 2025
deuszx
reviewed
Sep 17, 2025
deuszx
reviewed
Sep 17, 2025
- fixed comment typo - No unnecessary differentiation between initial state and updates - removed truncateFutureHistory - removed redo functionality
deuszx
reviewed
Sep 17, 2025
| // If we have a valid history position, replace it | ||
| if (this.currentHistoryIndex >= 0 && this.currentHistoryIndex < this.history.length) { | ||
| this.history[this.currentHistoryIndex] = state; | ||
| } else if (this.currentHistoryIndex === -1) { |
Contributor
There was a problem hiding this comment.
This damn zero-indexing :) we could also treat index === 0 as the initial, empty state. Then the if above changes to this.currentHistoryIndex > 0.
Not sure if we need to do this change right now, maybe too risky, but it'd simplify the logic.
Collaborator
Author
There was a problem hiding this comment.
yes, if its ok I can change it in a refactoring after the launch to not modify the logic this close :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixed game state management to prevent drawings from disappearing when navigating through generations.
Proposal
truncateFutureHistory)replaceCurrentState)Test Plan
tested it locally