First last key#6183
Open
MathieuDutSik wants to merge 12 commits into
Open
Conversation
Instruction Count Benchmark Results
Warning 5 instruction-count regression(s) detected (>1% threshold):
Deterministic metrics — reproducible across runs (34 benchmarks)
Cache-dependent metrics — expect fluctuations between runs (34 benchmarks)
|
afck
reviewed
May 4, 2026
| rpc ProcessDeleteNamespace (RequestDeleteNamespace) returns (google.protobuf.Empty) {} | ||
| rpc ProcessListAll (google.protobuf.Empty) returns (ReplyListAll) {} | ||
| rpc ProcessListRootKeys (RequestListRootKeys) returns (ReplyListRootKeys) {} | ||
| rpc ProcessDeleteAll (google.protobuf.Empty) returns (google.protobuf.Empty) {} |
Contributor
There was a problem hiding this comment.
(Why the Process prefix everywhere?)
| let response = response.into_inner(); | ||
| let ReplyFindLastKeyByPrefix { key } = response; | ||
| Ok(key) | ||
| } |
Contributor
There was a problem hiding this comment.
These methods share a lot of code; can that be deduplicated? Maybe they'd just pass in one or two closures to the same general method: what method to call on the client, and possibly what to do with the result?
| .find_last_key_value_by_prefix(key_prefix) | ||
| .await | ||
| .map_err(DualStoreError::Second), | ||
| } |
Contributor
There was a problem hiding this comment.
It seems this could also be deduplicated with a single generic method that does the matching and map_err?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a continuation of the existing PR #6171
by implementing the corrections that I asked.
Proposal
Add find_first_key_by_prefix, find_last_key_by_prefix, and the value variants to ReadableKeyValueStore, with default impls falling back to find_keys_by_prefix(...).first()/.last(). Native overrides:
For the wrappers:
linera-storage-serviceis also straightforward.find_keys_by_prefix,find_key_values_by_prefixto return result when possible.For the
ValueSplittingthis is harder since we can split some keys and anyway the remaining key could be leftover from previous big values that were deleted:find_first_key_by_prefixreturns a key that has index 0, we know it is ok, and we return. Otherwise, we do afind_keys_by_prefixwhich is expensive but should be very rare.find_first_key_value_by_prefix, if the obtained key has index 0 and the obtained value a count of 1, we know it is a legitimate one and we can return. Otherwise, we do an expensive but rarefind_key_values_by_prefix.Test Plan
CI
The test
map_view_mutabilitywas modified to use a Value splitting store. The way the keys are used has changed, but this is only because the generated key-set should be prefix-free.Release Plan
Can be backported to
testnet_conway.Links
None