Skip to content

Remove /client and use one from submodule#48

Merged
deuszx merged 1 commit intomainfrom
use-submodule
May 28, 2025
Merged

Remove /client and use one from submodule#48
deuszx merged 1 commit intomainfrom
use-submodule

Conversation

@deuszx
Copy link
Contributor

@deuszx deuszx commented May 28, 2025

Removes the /client directory and starts using the linera-web from linera-protocol submodule.

@deuszx deuszx requested a review from Twey May 28, 2025 10:19
this.wallet = wallet;
await linera;
this.client = await new linera.Client(await linera.Wallet.fromJson(wallet));
this.client = await new linera.Client({} as linera.Wallet); // Replace with actual wallet initialization
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromJson is removed from the linera-web client on linera-protocol.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is officially broken now; can we get a TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the TODO say? bring back fromJson?


Currently we only support building on Linux (`x86_64-unknown-linux-gnu`).

It depends on a `linera-protocol` project via git submodule.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to document how to use git in the git repository README, but I won't block on it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we document it or we automate it :) I don't expect people to read hidden files and if they follow README they get nowhere.

@deuszx
Copy link
Contributor Author

deuszx commented May 28, 2025

There are some issues related to nix. They should not be caused by this PR so I'll ignore them for now and merge.

@deuszx deuszx merged commit bdd1935 into main May 28, 2025
1 check failed
@Twey
Copy link
Collaborator

Twey commented May 28, 2025

GitHub is having some issues right now but we ran pnpm ci locally and this passed.

@Twey Twey mentioned this pull request Jun 20, 2025
@deuszx deuszx deleted the use-submodule branch June 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants