Skip to content

Print error-message if open fails #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print error-message if open fails #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions scripts/process_perfdata.pl.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ sub process_perfdata_file {
}

print_log( "reading $pdfile for bulk update", 2 );
open( PDFILE, "< $pdfile" );
open( PDFILE, "< $pdfile" ) || die "Can't open '$pdfile': $!";
my $count = 0;
while (<PDFILE>) {
my $job_data = $_;
Expand Down Expand Up @@ -763,7 +763,7 @@ sub read_custom_template {
if ( -e $template_cfg ) {
print_log( "DEBUG: adjust_template() => $template_cfg", 3 );
my $initial_dstype = $dstype;
open FH, "<", $template_cfg;
open FH, "<", $template_cfg || die "Can't open '$template_cfg': $!";
while (<FH>) {
next if /^#/;
next if /^$/;
Expand Down Expand Up @@ -842,7 +842,7 @@ sub parse_config {
my $line = 0;

if ( -e $config_file ) {
open CFG, '<', "$config_file";
open CFG, '<', "$config_file" || die "Can't open '$config_file': $!";
while (<CFG>) {
$line++;
chomp;
Expand Down Expand Up @@ -886,7 +886,7 @@ sub parse_rra_config {

if ( $rra_template ne "" ) {
@rrd_create = ();
open RRA, "<", $rra_template;
open RRA, "<", $rra_template || die "Can't open '$rra_template': $!";
while (<RRA>) {
next if /^#/;
next if /^$/;
Expand Down Expand Up @@ -1336,7 +1336,7 @@ sub store_internals {
sub check_internals {
my $file;
my @files;
opendir(STATS, $conf{'STATS_DIR'});
opendir(STATS, $conf{'STATS_DIR'}) || die "Can't open '$conf{'STATS_DIR'}': $!";
while ( defined ( my $file = readdir STATS) ){
next if $file =~ /^\.\.?$/; # skip . and ..
next if $file =~ /-PID-/; # skip temporary files
Expand All @@ -1357,7 +1357,7 @@ sub read_internals {
print_log( "ERROR: renaming stats file " . $conf{'STATS_DIR'}."/".$file . " to " . $conf{'STATS_DIR'}."/".$file."-PID-".$$ . " failed", 1 );
next;
}
open( STAT, "< ".$conf{'STATS_DIR'}."/".$file."-PID-".$$ );
open( STAT, "< ".$conf{'STATS_DIR'}."/".$file."-PID-".$$ ) || die "Can't open '$conf{'STATS_DIR'}/$file-PID-$$': $!";
%stats = (
timet => 0,
error => 0,
Expand Down Expand Up @@ -1491,7 +1491,7 @@ sub pidlock {
my $PIDFILE = $opt_pidfile;
if($action eq "create"){
if ( -e $PIDFILE ) {
if ( open( OLDPID, "<$PIDFILE" ) ) {
if ( open( OLDPID, "<$PIDFILE" ) || die "Can't open '$PIDFILE': $!") {
$_ = <OLDPID>;
chop($_);
my $oldpid = $_;
Expand Down Expand Up @@ -1528,7 +1528,7 @@ sub read_keyfile {
my $file = shift;
my $key = '';
if( -r $file){
open(FH, "<", $file);
open(FH, "<", $file) || die "Can't open '$file': $!";
while(<FH>){
chomp(); # avoid \n on last field
$conf{'KEY'} = $_;
Expand Down