-
-
Notifications
You must be signed in to change notification settings - Fork 428
feat(cli): support compile and extract with multi thread #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Zxilly changes from your PR:
I saw you added some rate limit to readFile util, i'm not sure why it's needed, could you elaborate? I'm also going to review the compile approach, probably some changes would be done there as well. I'll keep you posted. |
|
The rate limit was because I tried to apply my modified CLI in our production environment, and the process opened too many files, exceeding the operating system's file descriptor limit, as we have over 4,000 PO files. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
- Coverage 77.05% 76.36% -0.69%
==========================================
Files 84 92 +8
Lines 2157 2589 +432
Branches 555 667 +112
==========================================
+ Hits 1662 1977 +315
- Misses 382 486 +104
- Partials 113 126 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you continue working on #2318? I would like to continue contributing to this patch. |
|
@Zxilly please contact me in DM in the discord |
|
Sorry, I didn't see your Discord contact information in your profile. Could you please provide it? |
|
@Zxilly you can join a lingui server by this link https://discord.gg/gFWwAYnMtA and then you can find me in the contributing channel as "Tim Iatsenko" |
Description
Types of changes
Fixes # (issue)
Checklist