-
-
Notifications
You must be signed in to change notification settings - Fork 428
chore: deprecate Intl wrapper helpers and document removal #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
- Coverage 77.05% 76.60% -0.45%
==========================================
Files 84 100 +16
Lines 2157 2744 +587
Branches 555 715 +160
==========================================
+ Hits 1662 2102 +440
- Misses 382 513 +131
- Partials 113 129 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @yslpn thanks for the contribution. I'm not sure that developers would have enough time to transition and that will not block adoption ESM only linguijs. So it would be better to not remove it in the next major version. Blog post would be much apreciated to explain what was the driver for the decision. Meanwhile, do you think it would be nice to have ready to use react hooks as an alternative? Because users will still have to create them on their own, may be we can create them and make available out of the box? |
If we ship ready-made React hooks for date/number formatting, people will soon want the same helpers outside React, and we end up back where we were: maintaining wrappers around every Does that sound good to you?
I also drafted a blog post to explain the deprecation and migration; would love your take on it. The social image in the post was generated via AI (Nano Banana by Gemini). |
Description
Deprecate Lingui’s Intl wrappers (
i18n.date/numberplus the shared date/time/number helpers) ahead of removal, and add documentation callouts to direct users to nativeIntl.DateTimeFormat/Intl.NumberFormat, keeping the same locale precedence (i18n.locales ?? i18n.locale). Related: #2265.Open question for @timofei-iatsenko: do we also want a short blog for this deprecation, and is it OK to plan removal in the next major given the ESM-only focus discussed in #2363? Or it would be better to change the deprecated message.
Types of changes
Fixes #2265
Checklist