-
-
Notifications
You must be signed in to change notification settings - Fork 428
chore: new jsx transform #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: new jsx transform #2387
Conversation
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
…CallbackOrComponent
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 77.05% 76.61% -0.44%
==========================================
Files 84 100 +16
Lines 2157 2745 +588
Branches 555 715 +160
==========================================
+ Hits 1662 2103 +441
- Misses 382 513 +131
- Partials 113 129 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "peerDependencies": { | ||
| "@lingui/babel-plugin-lingui-macro": "5.7.0", | ||
| "babel-plugin-macros": "2 || 3", | ||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically speaking, this is a breaking change. Nothing wrong with that. But I say.. let's bump this to 18 and stop caring about the old versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. If we upgraded React, we could use useSyncExternalStore to sync react state with i18n state. It's a simpler and more performant option than using useEffect.
But I need other contributors' agreement that we're ready to upgrade React to version 18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrii-bodnar @timofei-iatsenko
What do you think about raising the React version to 18?
Description
Switch React packages to the automatic JSX runtime: Babel/esbuild now emit JSX without explicit
Reactimports, and the React tsconfig usesreact-jsx. Raised the minimum supportedreactpeer to16.14.0to align with the automatic runtime requirements. This follows the guidance in the new JSX transform announcement: https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.htmlTypes of changes
Fixes # N/A
Checklist