Skip to content

[MINOR] Added config flag to fetch disruption #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MINOR] Added config flag to fetch disruption #3066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ambry-api/src/main/java/com/github/ambry/config/ReplicationConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,11 @@ public class ReplicationConfig {
@Default("false")
public final boolean enableReplicationPrioritization;

public static final String ENABLE_DISRUPTION_SERVICE = "enable.disruption.service";
@Config(ENABLE_DISRUPTION_SERVICE)
@Default("true")
public final boolean enableDisruptionService;

/**
* The factory class the disruption service
*/
Expand Down Expand Up @@ -473,5 +478,7 @@ public ReplicationConfig(VerifiableProperties verifiableProperties) {
verifiableProperties.getBoolean(ENABLE_REPLICATION_PRIORITIZATION, false);
disruptionServiceFactory =
verifiableProperties.getString(DISRUPTION_SERVICE_FACTORY, DEFAULT_DISRUPTION_FACTORY);
enableDisruptionService =
verifiableProperties.getBoolean(ENABLE_DISRUPTION_SERVICE, true);
}
}
10 changes: 10 additions & 0 deletions ...c/main/java/com/github/ambry/replica/prioritization/ReplicationPrioritizationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public class ReplicationPrioritizationManager implements Runnable {
private final DisruptionService disruptionService;
private Map<PriorityTier, Set<PartitionId>> prioritizedPartitions;
private final ScheduledExecutorService scheduler;
private final ReplicationConfig replicationConfig;
/**
* Creates a new ReplicationPrioritizationManager.
*
Expand Down Expand Up @@ -108,6 +109,7 @@ public ReplicationPrioritizationManager(ReplicationEngine replicationEngine, Clu
this.disruptionService = disruptionService;
this.prioritizedPartitions = new EnumMap<>(PriorityTier.class);
this.scheduler = scheduler;
this.replicationConfig = replicationConfig;

// Schedule periodic runs for prioritization run
this.scheduler.scheduleAtFixedRate(this, 0, scheduleIntervalMinutes, TimeUnit.MINUTES);
Expand Down Expand Up @@ -237,6 +239,14 @@ void startPrioritizationCycle() {
*/
private Map<PartitionId, List<Operation>> fetchDisruptions(List<PartitionId> partitionIds) {
Map<PartitionId, List<Operation>> disruptionsByPartition = new HashMap<>();

if (!replicationConfig.enableDisruptionService) {
for (PartitionId partitionId : partitionIds) {
disruptionsByPartition.computeIfAbsent(partitionId, k -> new ArrayList<>());
}
return disruptionsByPartition;
}

try {
// 3. Fetch disruptions for all partitions
disruptionsByPartition =
Expand Down
Loading