Modify RmdUtils:getLastUpdateTimestamp to fix class cast exception #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynameborat
reviewed
Dec 8, 2025
Contributor
mynameborat
left a comment
mynameborat
left a comment
There was a problem hiding this comment.
Can you make sure there is enough coverage in unit test? Looks like some of the code coverage checks are failing.
Comment on lines
+175
to
+176
| @Test | ||
| public void testGetLastUpdateTimestampWithCollectionFields() { |
Contributor
There was a problem hiding this comment.
If there is not an existing test, can you add one for the top level field that contributes to maximum?
Comment on lines
+161
to
+174
| // Handle DELETED_ELEM_TS_FIELD_NAME as a List/Collection | ||
| Object deletedTimestamps = fieldRecord.get(DELETED_ELEM_TS_FIELD_NAME); | ||
| if (deletedTimestamps instanceof List) { | ||
| for (Object ts: (List<?>) deletedTimestamps) { | ||
| lastUpdatedTimestamp = Math.max(lastUpdatedTimestamp, ((Number) ts).longValue()); | ||
| } | ||
| } | ||
| for (long timestamp: (long[]) ((GenericRecord) ((GenericRecord) timestampRecord).get(field.name())) | ||
| .get(ACTIVE_ELEM_TS_FIELD_NAME)) { | ||
| lastUpdatedTimestamp = Math.max(lastUpdatedTimestamp, timestamp); | ||
|
|
||
| // Handle ACTIVE_ELEM_TS_FIELD_NAME as a List/Collection | ||
| Object activeTimestamps = fieldRecord.get(ACTIVE_ELEM_TS_FIELD_NAME); | ||
| if (activeTimestamps instanceof List) { | ||
| for (Object ts: (List<?>) activeTimestamps) { | ||
| lastUpdatedTimestamp = Math.max(lastUpdatedTimestamp, ((Number) ts).longValue()); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we extract maximum inference to a method? Looks boiler plate.
|
|
||
| // Handle DELETED_ELEM_TS_FIELD_NAME as a List/Collection | ||
| Object deletedTimestamps = fieldRecord.get(DELETED_ELEM_TS_FIELD_NAME); | ||
| if (deletedTimestamps instanceof List) { |
Contributor
There was a problem hiding this comment.
Does instanceof List check covers all types of collection in avro?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Caused by: java.lang.ClassCastException: class org.apache.avro.generic.GenericData$Array cannot be cast to class [J (org.apache.avro.generic.GenericData$Array is in unnamed module of loader 'app'; [J is in module java.base of loader 'bootstrap')
GenericDataArray treats the collection as list opposed to long[] array. Fixing the same.
Solution
Treat DELETED_ELEM_TS_FIELD_NAME and ACTIVE_ELEM_TS_FIELD_NAME as List/Collection instead of long array
How was this PR tested?
Unit tests