Skip to content

Conversation

@misyel
Copy link
Contributor

@misyel misyel commented Jan 8, 2026

Problem Statement

Repush ttl seconds value is optionally passed in when a job runs but there is no way to verify the repush ttl seconds for the version afterwards if the value was changed after the run

Solution

Add repush ttl seconds to add version in admin operation so that we can set the field when we create a new version

{
              "name": "repushTtlSeconds",
              "type": "int",
              "doc": "For store version created from repush, indicates the time-to-live in seconds set during the repush",
              "default": -1
}

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Existing CI

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

@misyel misyel enabled auto-merge (squash) January 8, 2026 00:39
@misyel misyel merged commit bc91dc8 into linkedin:main Jan 8, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants