Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] allow cni updateStrategy to be configurable #13562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sstarcher
Copy link

  • For users with large clusters rollout of the cni can take a bit of time. This will allow them to configure a faster rollout of the cni resources.

Fixes #13031

@sstarcher sstarcher requested a review from a team as a code owner January 14, 2025 12:55
@sstarcher sstarcher force-pushed the feature/updateStrategy branch 2 times, most recently from d45565d to 89b8288 Compare January 14, 2025 12:58
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sstarcher! 👍

For the CLI-based method to work with your change, please add this to the Values struct in ./pkg/charts/cni/values.go:

	UpdateStrategy       map[string]interface{} `json:"updateStrategy"`

And then make sure you run go test ./... -update to update the test fixtures.

Shane Starcher added 2 commits January 17, 2025 13:34
* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

linkerd#13031
Signed-off-by: Shane Starcher <[email protected]>
Signed-off-by: Shane Starcher <[email protected]>
@sstarcher sstarcher force-pushed the feature/updateStrategy branch from d90342a to d719013 Compare January 17, 2025 18:35
@sstarcher
Copy link
Author

tried both of the following and they error out
go test ./... --update
go test ./... -update

I also did go test ./cli/cmd/... --update, but no changes

@alpeb
Copy link
Member

alpeb commented Jan 17, 2025

But when it errors out, it does generate changes in the golden files, no? With those changes, go test ./... should pass.

@sstarcher
Copy link
Author

sstarcher commented Jan 17, 2025

running go test ./... -update does not change any files. The error I see is it saying -update is an invalid arg. I'm running this from the root of the repo.

FAIL github.com/linkerd/linkerd2/viz/tap/pkg 0.021s
flag provided but not defined: -update
Usage of /tmp/go-build3818748008/b1710/srv.test:
-test.bench regexp
run only benchmarks matching regexp
-test.benchmem
print memory allocations for benchmarks
-test.benchtime d
run each benchmark for duration d or N times if d is of the form Nx (default 1s)
-test.blockprofile file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart to allow for configuration of updateStrategy
2 participants