Skip to content

Housekeeping: changelog updates etc. - #165

Merged
dalito merged 9 commits into
linkml:mainfrom
dalito:issue164-housekeeping-changelog
May 27, 2026
Merged

Housekeeping: changelog updates etc.#165
dalito merged 9 commits into
linkml:mainfrom
dalito:issue164-housekeeping-changelog

Conversation

@dalito

@dalito dalito commented May 26, 2026

Copy link
Copy Markdown
Member

The PR contains mostly documentation changes:

  • Add last release v0.4.2 to the changelog and the changes made afterwards
  • Improve wording in Acknowledgement part of README
  • Add @noelmcloughlin as another creator in Zenodo metadata (Why? He has contributed more than 10 commits). Noel, let me know your affiliation and ORCID if want to have it added.

Non-documentation change:

  • Added a validator to the copier config (setup questions) to prevent a crash for invalid project names.

Please only approve. Do not merge. I like to integrate the planned new release into the changelog. @matentzn

Closes #164

@dalito dalito added the _repo Related to the template-repository label May 26, 2026
@dalito
dalito requested a review from matentzn May 26, 2026 10:06

@matentzn matentzn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@dalito dalito added this to the Release 0.5.0 milestone May 26, 2026
@dalito
dalito force-pushed the issue164-housekeeping-changelog branch from bfc6545 to f28825a Compare May 26, 2026 15:01
@dalito

dalito commented May 26, 2026

Copy link
Copy Markdown
Member Author

Updated CHANGELOG to reference the next Release v0.5.0 planned for tomorrow evening.

This PR should only be merged after #162.

@dalito dalito changed the title Housekeeping: changelog updates Housekeeping: changelog updates etc. May 26, 2026
@dalito dalito self-assigned this May 27, 2026
@dalito
dalito force-pushed the issue164-housekeeping-changelog branch from ec390dc to ba8fcb0 Compare May 27, 2026 13:44
@dalito

dalito commented May 27, 2026

Copy link
Copy Markdown
Member Author

Rebased and resolved conflicts. Also addressed the comments added in #170 after merge.

@matentzn matentzn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, your call!

@@ -1,4 +1,4 @@
"""{{project_name}}
"""{{project_name}}.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that occasionally projects might contain a period so # noqa might be more robust then adding a period

@dalito dalito May 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edge case. I ended up adding a validator which prevents a dot at the end of the project name. Without the validator a dot at the end of the name even caused an exception in slugify.

@dalito
dalito force-pushed the issue164-housekeeping-changelog branch from 557f36e to 852b083 Compare May 27, 2026 17:36
dalito added 2 commits May 27, 2026 21:08
Also reduce length of validation message as copier's statusline
provided by the prompt_toolkit is limited to one line.
@dalito
dalito force-pushed the issue164-housekeeping-changelog branch from 852b083 to 4534208 Compare May 27, 2026 19:18
@dalito
dalito merged commit 1d52a14 into linkml:main May 27, 2026
11 checks passed
@dalito
dalito deleted the issue164-housekeeping-changelog branch May 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

_repo Related to the template-repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update changelog

2 participants