Skip to content

Document stable Rust support#26

Open
konard wants to merge 5 commits intomainfrom
issue-22-52cb3422
Open

Document stable Rust support#26
konard wants to merge 5 commits intomainfrom
issue-22-52cb3422

Conversation

@konard
Copy link
Copy Markdown
Member

@konard konard commented Sep 11, 2025 •
edited
Loading

Summary

This PR is now rebased/merged onto the current main branch and keeps the complete stable-Rust migration that already landed through PR 48. The old branch's obsolete fallback implementation and legacy workflow edits are not carried forward.

Changes in this PR:

  • Update README installation docs to use doublets 0.3.0 and stable Rust 1.85+ instead of nightly Rust.
  • Update CONTRIBUTING setup instructions to reflect the stable rust-toolchain.toml configuration.
  • Add STABLE_RUST.md with the current stable toolchain, crates.io dependency, and Miri/nightly distinction.
  • Add a changelog fragment for the documentation fix.
  • Sync the Cargo.lock doublets package entry with the released 0.3.0 crate version.

Verification

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features
  • cargo test --all-features --verbose
  • cargo test --doc --verbose
  • rust-script scripts/check-file-size.rs
  • rust-script scripts/check-readme-badges.rs
  • GITHUB_BASE_REF=main rust-script scripts/check-changelog-fragment.rs
  • GITHUB_EVENT_NAME=pull_request GITHUB_HEAD_REF=issue-22-52cb3422 GITHUB_BASE_REF=main rust-script scripts/check-version-modification.rs
  • git diff --check origin/main...HEAD

Notes:

  • The old failed PR check logs from September 11, 2025 are expired on GitHub and return HTTP 410, so the branch was verified locally and a fresh CI run is triggered by this push.
  • origin/main is merged into this branch, so the previous PR conflict should be resolved.

Closes #22

@konard
Initial commit with task details for issue #22
306c9f3 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #22
@konard konard self-assigned this Sep 11, 2025
konard and others added 2 commits September 11, 2025 08:11
@konard
Remove CLAUDE.md - PR created successfully
0ff9f66
@konard @claude
Remove dependency on nightly Rust versions
f0493bd 
This resolves issue #22 by making doublets-rs compatible with stable Rust.

## Key Changes:

### CI Configuration
- Updated GitHub workflows to use stable Rust toolchain by default
- Miri job continues to use nightly (required for Miri)

### Feature Flag System
- Added 'nightly' feature flag for advanced functionality
- Made platform dependencies (data, mem, trees) optional
- Conditional compilation for nightly-only features

### Stable Rust Support
- Created stable_lib.rs with basic doublets functionality
- Added stable fallback implementations
- Example demonstrating stable Rust usage

### Benefits
- ✅ Compiles with stable Rust (basic functionality)
- ✅ Full functionality still available with nightly + feature flags
- ✅ Reduced barrier to entry for new users
- ✅ More reliable CI builds

## Usage

Stable Rust (basic): cargo check --no-default-features
Full functionality: cargo check --features "nightly,data,mem"

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Remove dependency on nightly versions Remove dependency on nightly Rust versions Sep 11, 2025
@konard konard marked this pull request as ready for review September 11, 2025 05:26
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 18, 2026

We need resolve conflicts, and double check that we use all the best practices from this pull request in current version of the codebase.

So everything useful from this request is applied.

We need to ensure all changes are correct, consistent, validated, tested, logged and fully meet each and all discussed requirements (check issue description and all comments in issue and in pull request). Ensure all CI/CD checks pass.

@konard konard marked this pull request as draft April 18, 2026 23:51
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 18, 2026

🤖 AI Work Session Started

Starting automated work session at 2026-04-18T23:51:50.695Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard changed the title Remove dependency on nightly Rust versions Document stable Rust support Apr 19, 2026
@konard konard marked this pull request as ready for review April 19, 2026 00:05
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 19, 2026

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: gpt-5.4
  • Provider: OpenAI
  • Public pricing estimate: unknown
  • Token usage: 495,448 input, 31,755 output, 16,640,128 cache read

📊 Context and tokens usage:

Total: (495.4K + 16.6M cached) input tokens, 31.8K output tokens

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.4
  • Model: GPT-5.4 (gpt-5.4)

📎 Log file uploaded as Repository (42777KB)

Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 19, 2026

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dependency on nightly versions

1 participant

@konard