fix phase #60
Open
fix phase #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zohar
reviewed
Sep 12, 2018
| /profiles/openideal/sublime-openideal.sublime-project | ||
| /profiles/openideal/sublime-openideal.sublime-workspace | ||
| /.gitk-tmp.11456/ | ||
| /.gitk-tmp.11456/ |
There was a problem hiding this comment.
@israelLinnovate @nevos Can you make this more generic? (for example .gitk-tmp*)
There was a problem hiding this comment.
although it's not at all relevant to the PR..
zohar
reviewed
Sep 12, 2018
| $phase = t('Phase'); | ||
|
|
||
| if (!empty($entity->field_in_action)){ | ||
| $phase = $entity->field_in_action["und"][0]["value"]; |
There was a problem hiding this comment.
Make sure this string is safe (escaped as necessary)
@Israel123
zohar
reviewed
Sep 12, 2018
| } | ||
|
|
||
| // Hardcode phase for now. | ||
| $phase = t('Phase'); |
There was a problem hiding this comment.
We need to have a default Phase, probably through the field's configuration.
For now, change the initial value to "Ideation"
@israelLinnovate
nvelychenko
referenced
this pull request
in istolar/openideal
Sep 22, 2020
OI-39: #comment Added condition to check if voted the same user that created the idea.
nvelychenko
added a commit
that referenced
this pull request
Mar 14, 2021
OI-298: Fix notifications bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.