Skip to content

Update LDE Node Pool Assertion and Test env variable Handling #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented May 12, 2025

📝 Description

Address assertion failure, changed it to be more flexible asserting if lde has an explicitly set value upon cluster creation

Now makefile uses LINODE_ env vars if set, falls back to TEST_ if not, and finally uses hardcoded defaults when neither is available — making the setup more consistent with other repositories

✔️ How to Test

Test environment variables:

# run it against alpha or staging
unset TEST_API_URL TEST_API_VERSION TEST_API_CA
export LINODE_TOKEN="token"
export TEST_API_URL="https://api.dev.linode.com" 
export LINODE_API_VERSION="v4beta"
export LINODE_CA="/tmp/test_ca.pem"

make test-int TEST_SUITE=api_request_basic

# unset these test vars
unset LINODE_API_URL LINODE_API_VERSION LINODE_CA

export LINODE_API_TOKEN="alpha_token"
export TEST_API_URL="https://api.dev.linode.com/"
export TEST_API_VERSION="v4beta"
export TEST_API_CA="/tmp/test_ca.pem"

make test-int TEST_SUITE=api_request_basic

Test LKE assertion changes:

make TEST_SUITE="lke_cluster_basic" test-int 
 make TEST_SUITE="lke_node_pool_basic" test-int

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner May 12, 2025 23:43
@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label May 12, 2025
@ykim-akamai ykim-akamai requested review from lgarber-akamai and zliang-akamai and removed request for a team May 12, 2025 23:43
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end. Great quality of life improvement and nice work!

@ykim-akamai ykim-akamai merged commit 1789d1b into linode:dev May 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants