Skip to content

feat: add agent page tabs #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ferruhcihan wants to merge 41 commits into
base: main
Choose a base branch
from
Open

feat: add agent page tabs #665

ferruhcihan wants to merge 41 commits into from

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Oct 22, 2025

📌 Summary

This PR updates the agent page with tabs.

Ticket: https://track.akamai.com/jira/browse/APL-1199
Figma: https://www.figma.com/design/12oYPXhQvdQhsQiFZJzWGW/RFC-APL-1118-PoC?node-id=54-208&t=ZTGVrZz2N0zlTWSe-0
Related PRs: apl-core || apl-api

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@ElderMatt ElderMatt self-assigned this Oct 22, 2025
@ElderMatt
Copy link
Contributor

ElderMatt commented Oct 22, 2025

How does the user know that something needs to be filled in on page playground?
image
image

dennisvankekem
dennisvankekem approved these changes Oct 24, 2025
View reviewed changes
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice touch to add the descriptions

@j-zimnowoda j-zimnowoda self-requested a review December 15, 2025 12:58
j-zimnowoda
j-zimnowoda requested changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on-hold

@j-zimnowoda j-zimnowoda added the on hold Waiting for another party to do something label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda requested changes

@ElderMatt ElderMatt ElderMatt approved these changes

@dennisvankekem dennisvankekem dennisvankekem approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@ElderMatt ElderMatt

Labels

on hold Waiting for another party to do something

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ferruhcihan @ElderMatt @j-zimnowoda @dennisvankekem @svcAPLBot @CasLubbers