-
Notifications
You must be signed in to change notification settings - Fork 171
ci: removed standard-version config in package.json #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the regular release pipeline. I am pretty sure that it relies on that setting?
Coverage report
Show files with reduced coverage 🔻
Test suite run success93 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 164f47d |
@@ -166,11 +166,6 @@ | |||
"bootstrap-dev-with-repo": "CI=1 ENV_DIR=/tmp/otomi-bootstrap-dev binzx/otomi bootstrap", | |||
"bootstrap-tests-fixtures": "CI=1 ENV_DIR=$PWD/tests/fixtures binzx/otomi bootstrap" | |||
}, | |||
"standard-version": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check with Create and push git tag
task. In particular how changing this config impacts the following statement:
git tag -am "$COMMIT_MSG" $release_tag && git push --follow-tags
📌 Summary
While trying to generate our first release candidate, the pipeline failed because of a missing tag which should have been created by running the release command.
Apparently this behavior was disabled in packages.json.
🔍 Reviewer Notes
🧹 Checklist