Skip to content

ci: removed standard-version config in package.json #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Apr 27, 2025

📌 Summary

While trying to generate our first release candidate, the pipeline failed because of a missing tag which should have been created by running the release command.
Apparently this behavior was disabled in packages.json.

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the regular release pipeline. I am pretty sure that it relies on that setting?

Copy link

github-actions bot commented Apr 28, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
49.36% (+0.09% 🔼)
1079/2186
🔴 Branches
33.13% (+0.31% 🔼)
214/646
🔴 Functions
41.25% (+0.33% 🔼)
125/303
🔴 Lines
48.75% (+0.15% 🔼)
956/1961
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 common/utils.ts 67.63%
50% (-1.32% 🔻)
54.55%
69.12% (+0.74% 🔼)

Test suite run success

93 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 164f47d

@@ -166,11 +166,6 @@
"bootstrap-dev-with-repo": "CI=1 ENV_DIR=/tmp/otomi-bootstrap-dev binzx/otomi bootstrap",
"bootstrap-tests-fixtures": "CI=1 ENV_DIR=$PWD/tests/fixtures binzx/otomi bootstrap"
},
"standard-version": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check with Create and push git tag task. In particular how changing this config impacts the following statement:

git tag -am "$COMMIT_MSG" $release_tag && git push --follow-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants