feat: add apl-operator #2151
Draft
feat: add apl-operator #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success93 tests passing in 9 suites. Report generated by 🧪jest coverage report action from a223e5e |
j-zimnowoda
reviewed
May 13, 2025
helmfile.d/helmfile-09.init.yaml
Outdated
| app: core | ||
| <<: *default | ||
| # - name: otomi-pipelines | ||
| # installed: true |
There was a problem hiding this comment.
I would actually set it to false, so we ensure that corresponding app is removed
j-zimnowoda
reviewed
May 13, 2025
src/common/envalid.ts
Outdated
| @@ -32,6 +32,8 @@ export const cliEnvSpec = { | |||
| RANDOM: bool({ desc: 'Randomizes the timeouts by multiplying with a factor between 1 to 2', default: false }), | |||
| MIN_TIMEOUT: num({ desc: 'The number of milliseconds before starting the first retry', default: 60000 }), | |||
| FACTOR: num({ desc: 'The factor to multiply the timeout with', default: 1 }), | |||
| GITEA_URL: str({ default: 'gitea-http.gitea.svc.cluster.local:3000' }), | |||
There was a problem hiding this comment.
GITEA_URL could be split into:
GITEA_HOST and GITEA_PORT
There was a problem hiding this comment.
Perhaps also instead of GITEA we could use GIT because the operator is git repo provider agnostic
j-zimnowoda
reviewed
May 13, 2025
src/operator/apl-operator.ts
Outdated
| export class AplOperator { | ||
| private d = terminal('operator:apl') | ||
| private isRunning = false | ||
| private pollInterval = 1000 |
There was a problem hiding this comment.
It could be configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
🔍 Reviewer Notes
🧹 Checklist