Skip to content

[breaking] Simplify field names for OBJ bucket, fix broken flatcar link in docs #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

AshleyDumaine
Copy link
Contributor

What this PR does / why we need it: This simplifies the field name for the OBJ Bucket Secret

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@AshleyDumaine AshleyDumaine changed the title Simplify field names for OBJ bucket, fix broken flatcar link in docs [breaking] Simplify field names for OBJ bucket, fix broken flatcar link in docs May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (a95ddfa) to head (1ef6e2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cloud/scope/machine.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   62.91%   62.91%           
=======================================
  Files          69       69           
  Lines        6671     6671           
=======================================
  Hits         4197     4197           
  Misses       2240     2240           
  Partials      234      234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine merged commit 62704e6 into main May 16, 2025
17 checks passed
@AshleyDumaine AshleyDumaine deleted the field-renaming branch May 16, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants