Add warnings to deprecated OBJ API usage #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
yec-akamai
commented
May 29, 2024
| @@ -463,8 +465,14 @@ def access(self, cluster, bucket_name, permissions): | |||
| } | |||
|
|
|||
|
|
|||
| @deprecated( | |||
There was a problem hiding this comment.
Since we need to deprecate the cluster-view, I assume that we want to deprecate the ObjectStorageCluster class. I'm also wondering if we should move the function buckets_in_cluster from here to the obj_storage group.
There was a problem hiding this comment.
I think it's a good idea 👍
yec-akamai
added
the
improvement
ykim-akamai
approved these changes
May 31, 2024
|
|
|
import warnings
def deprecated_feature():
warnings.warn("deprecated", DeprecationWarning)Never mind, now I think |
|
There will also be a deprecated decorator the standard library of Python 3.13, but we probably can't use it during these years since it's not available in earlier versions of Python. |
zliang-akamai
added a commit
that referenced
this pull request
Jul 5, 2024
* Add warnings to deprecated OBJ API usage (#410) * add deprecated * add dependency * fix deprecated * Update OBJ Group and Objects for MultiCluster Object Storage API Changes (#426) --------- Co-authored-by: Ye Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add warnings in docs and to related functions to deprecate two endpoints: cluster-view and cluster-list.