-
Notifications
You must be signed in to change notification settings - Fork 94
Add support for creation of NB with IPv4 Reserved Address #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, pending test environment for release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank for for the contribution. Will approve after testing.
Just an update for those watching. The production updates to the Linode API required to support this are currently scheduled for next week (9/14 and 9/16). I'll update the PR once they are successfully rolled out. |
📝 Description
This adds support for creating a NodeBalancer with a reserved IP address. It will be supported by an upcoming release to modify Linode API to accept reserved IPs at the creation of a NodeBalancer. This is needed to support the creation of Service LoadBalancers with reserved IPs in LKE.
✔️ How to Test
Customer flags required:
Relevant unit tests can be run using:
Relevant files: