Skip to content

Add support for creation of NB with IPv4 Reserved Address #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

hcwagner
Copy link

@hcwagner hcwagner commented Apr 29, 2025

📝 Description

This adds support for creating a NodeBalancer with a reserved IP address. It will be supported by an upcoming release to modify Linode API to accept reserved IPs at the creation of a NodeBalancer. This is needed to support the creation of Service LoadBalancers with reserved IPs in LKE.

✔️ How to Test

Customer flags required:

  • reserved_ips_beta
  • can_reserve_ip
  • reserved_ip_nodebalancer

Relevant unit tests can be run using:

make TEST_ARGS="-run TestNodeBalancer" test-unit

Relevant files:

  • test/unit/fixtures/nodebalancer_create_with_ipv4.json
  • test/unit/nodebalancer_test.go

@hcwagner hcwagner requested a review from a team as a code owner April 29, 2025 18:44
@hcwagner hcwagner requested review from jriddle-linode and ezilber-akamai and removed request for a team April 29, 2025 18:44
@hcwagner hcwagner closed this May 8, 2025
@hcwagner hcwagner deleted the nd-ip-reserve branch May 8, 2025 19:01
@hcwagner hcwagner restored the nd-ip-reserve branch May 8, 2025 19:02
@hcwagner hcwagner reopened this May 8, 2025
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, pending test environment for release.

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank for for the contribution. Will approve after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants