project: UDP NodeBalancers #751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * Finish up * Add integration tests * Add NB unit test * Add config unit test * Replace TODO * Render fixtures * Re-render unrelated fixture
ezilber-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
ezilber-akamai
added
do-not-merge
ezilber-akamai
force-pushed
the
proj/nb-udp
branch
from
098dd6e to
dcab891
Compare
ezilber-akamai
force-pushed
the
proj/nb-udp
branch
from
6dd6a44 to
e0668d8
Compare
ezilber-akamai
force-pushed
the
proj/nb-udp
branch
2 times, most recently
from
b8a79cc to
3c8e57c
Compare
jriddle-linode
approved these changes
May 16, 2025
rahulait
reviewed
May 16, 2025
| @@ -160,6 +168,7 @@ func (i NodeBalancerConfig) GetCreateOptions() NodeBalancerConfigCreateOptions { | |||
| CheckPath: i.CheckPath, | |||
| CheckBody: i.CheckBody, | |||
| CheckPassive: copyBool(&i.CheckPassive), | |||
| UDPCheckPort: &i.UDPCheckPort, | |||
There was a problem hiding this comment.
We should set it only if protocol is UDP. This field is not optional in NodeBalancerConfig, so if you don't set it there (ex for TCP protocol), it gets default 0. If then someone does GetCreateOptions() for that NodeBalancerConfig, returned NodeBalancerConfigCreateOptions has UDPCheckPort assigned value 0 and that will make calls to fail as udp_check_port has to be within 1 to 65535.
rahulait
reviewed
May 16, 2025
| @@ -181,6 +190,7 @@ func (i NodeBalancerConfig) GetUpdateOptions() NodeBalancerConfigUpdateOptions { | |||
| CheckBody: i.CheckBody, | |||
| CheckPassive: copyBool(&i.CheckPassive), | |||
| CheckTimeout: i.CheckTimeout, | |||
| UDPCheckPort: copyInt(&i.UDPCheckPort), | |||
There was a problem hiding this comment.
Same here, set only for UDP protocol
rahulait
reviewed
May 16, 2025
| @@ -202,6 +212,7 @@ func (i NodeBalancerConfig) GetRebuildOptions() NodeBalancerConfigRebuildOptions | |||
| CheckPath: i.CheckPath, | |||
| CheckBody: i.CheckBody, | |||
| CheckPassive: copyBool(&i.CheckPassive), | |||
| UDPCheckPort: copyInt(&i.UDPCheckPort), | |||
There was a problem hiding this comment.
Same here, set only for UDP protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request merges the NodeBalancer UDP project into this project's main branch to be included in the next release.
✔️ How to Test
The following test steps assume you have pulled down this PR locally and are using an account with access to UDP NodeBalancers.
Unit Tests
make test-unitIntegration Tests
make fixtures TEST_ARGS="-run TestNodeBalancer"