upcoming: [M3-9539] - Quotas Tab Beta Chip #11872
Conversation
abailly-akamai
requested review from
harsh-akamai,
jdamore-linode and
mjac0bs
and removed request for
a team
|
Coverage Report: ❌ |
There was a problem hiding this comment.
Navigate to /account and confirm new chip
👋🏼 new chip
Confirm no regression with existing instances of beta chip (Primary Nav, Database Create)
These look good. What was UX's guidance for when to use the secondary color vs. primary?
(Asking because I'm wondering whether ApplicationPlatform for LKE should use the secondary color at some point. Currently, it doesn't even use a BetaChip; it uses a Chip for which the label is "BETA". That works for now while APL is disabled for LKE-E, but making a ticket [M3-9608] to switch this over to a BetaChip in the future while I'm here...)
@mjac0bs I think it really just has to do wether the chip applies on a dark VS light background. (in that regard primary VS secondary could be arguably reversed but wanted to keep thing simple and scoped for this PR). The primary beta chip was first only in the PrimaryNav but has now exapanded to the rest of the App but the primary styles contrast poorly on the white bg |
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
looks good, thank you!
coliu-akamai
added
Approved
Cloud Manager UI test results🎉 533 passing tests on test run #8 ↗︎
|
* save progress * Add proper colors for secondary styles * fix test * Delete old instance of BetaChip * Changesets
4 participants
Description 📝
Small PR to add a Beta Chip to the /account "Quota" tab.
<BetaChip />inmanager/src/components/after migrating it to@linode/uicolorprop was also broken (default/primary were doing the same thing) so I added a secondary prop instead and if no color is passed it'll default to primary. No change for existing instances since they were all already inheriting the primary styles.Changes 🔄
<BetaChip />inmanager/src/components/<BetaChip >colorpropPreview 📷
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅