Skip to content

Conversation

@jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Mar 18, 2025

Description 📝

Update the input field title in the bucket creation form from "Label" to "Bucket Name" to improve clarity. While the API refers to this field as label, using "Bucket Name" in the UI will prevent future confusion when bucket tagging is implemented.

Note

Technical Details: No changes to API contract required. UI change only, backend will continue to use label field name

Changes 🔄

  • Renamed Label to Bucket Name
  • Update validation
  • Update E2E tests

Target release date 🗓️

3/25

Preview 📷

Before After
Screenshot 2025-03-18 at 3 09 20 PM Screenshot 2025-03-18 at 2 33 48 PM

How to test 🧪

Prerequisites

Verification steps

  • Ensure you can create buckets still
  • Ensure validation reflects changes
  • Ensure all E2E tests pass
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai added the Object Storage deals with Object Storage label Mar 18, 2025
@jaalah-akamai jaalah-akamai self-assigned this Mar 18, 2025
@jaalah-akamai jaalah-akamai requested review from a team as code owners March 18, 2025 19:10
@jaalah-akamai jaalah-akamai requested review from bnussman-akamai, coliu-akamai and dmcintyr-akamai and removed request for a team March 18, 2025 19:10
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ can still create buckets
✅ validation looks good (should Name in Bucket Name be capitalized for the validation message?)

❓ I'm seeing some test failures - approving pending their resolution:

  • unit test failure in OMC_CreateBucketDrawer.test.tsx looks relevant
  • There are some additional cypress tests that still use label inside the objectStoragegen2/objectStorageMulticluster packages
    • bucket-create-gen2.spec.ts
    • bucket-create-multicluster.spec.ts

image

thanks Jaalah!

@jaalah-akamai
Copy link
Contributor Author

Thanks @coliu-akamai that should do it, but I'll check the e2e pipeline for anything else 👍

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 19, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 19, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 19, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing538 Passing3 Skipped103m 54s

Details

Failing Tests
SpecTest
update-firewall.spec.tsupdate firewall » updates a firewall's label

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/update-firewall.spec.ts"

@jaalah-akamai jaalah-akamai merged commit 283419b into linode:develop Mar 19, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Object Storage deals with Object Storage

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants