-
Notifications
You must be signed in to change notification settings - Fork 389
change: [M3-9601] - Replace Label with Bucket Name #11877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ can still create buckets
✅ validation looks good (should Name in Bucket Name be capitalized for the validation message?)
❓ I'm seeing some test failures - approving pending their resolution:
- unit test failure in
OMC_CreateBucketDrawer.test.tsxlooks relevant - There are some additional cypress tests that still use label inside the objectStoragegen2/objectStorageMulticluster packages
- bucket-create-gen2.spec.ts
- bucket-create-multicluster.spec.ts
thanks Jaalah!
|
Thanks @coliu-akamai that should do it, but I'll check the e2e pipeline for anything else 👍 |
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/update-firewall.spec.ts" |
|||||||||||||||||

Description 📝
Update the input field title in the bucket creation form from "Label" to "Bucket Name" to improve clarity. While the API refers to this field as
label, using "Bucket Name" in the UI will prevent future confusion when bucket tagging is implemented.Note
Technical Details: No changes to API contract required. UI change only, backend will continue to use
labelfield nameChanges 🔄
LabeltoBucket NameTarget release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅