-
Notifications
You must be signed in to change notification settings - Fork 389
upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch #11880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjac0bs
merged 3 commits into
linode:develop
from
mjac0bs:M3-9517-lde-disabled-for-lke-e-2
Mar 19, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-11880-upcoming-features-1742329364209.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Update LKE-E flows to account for LDE status at LA launch ([#11880](https://github.com/linode/manager/pull/11880)) |
6 changes: 6 additions & 0 deletions
6
packages/manager/src/features/Kubernetes/ClusterList/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| export const ADD_NODE_POOLS_DESCRIPTION = | ||
| 'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool and a maximum of 250 Linodes per cluster.'; | ||
|
|
||
| export const ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION = | ||
| 'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool.'; | ||
|
|
||
| export const ADD_NODE_POOLS_ENCRYPTION_DESCRIPTION = | ||
| 'Node Pool data is encrypted at rest.'; | ||
|
|
||
| export const ADD_NODE_POOLS_NO_ENCRYPTION_DESCRIPTION = | ||
| 'Node Pool data is not encrypted at rest for LKE Enterprise clusters.'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { useAllLinodesQuery, useProfile } from '@linode/queries'; | ||
| import { Box, ErrorState, TooltipIcon, Typography } from '@linode/ui'; | ||
| import { DateTime, Interval } from 'luxon'; | ||
| import { enqueueSnackbar } from 'notistack'; | ||
|
|
@@ -20,7 +21,6 @@ import { TableRow } from 'src/components/TableRow'; | |
| import { TableSortCell } from 'src/components/TableSortCell'; | ||
| import { TagCell } from 'src/components/TagCell/TagCell'; | ||
| import { useUpdateNodePoolMutation } from 'src/queries/kubernetes'; | ||
| import { useAllLinodesQuery, useProfile } from '@linode/queries'; | ||
| import { parseAPIDate } from 'src/utilities/date'; | ||
| import { getAPIErrorOrDefault } from 'src/utilities/errorUtils'; | ||
|
|
||
|
|
@@ -270,8 +270,17 @@ export const NodeTable = React.memo((props: Props) => { | |
| </Typography> | ||
| <StyledVerticalDivider /> | ||
| <EncryptedStatus | ||
| /** | ||
|
||
| * M3-9517: Once LDE starts releasing regions with LDE enabled, LDE will still be disabled for the LKE-E LA launch, so hide this tooltip | ||
| * explaining how LDE can be enabled on LKE-E node pools. | ||
| * TODO - LKE-E: Clean up this enterprise cluster checks once LDE is enabled for LKE-E. | ||
| */ | ||
| tooltipText={ | ||
| clusterTier === 'enterprise' | ||
| ? undefined | ||
| : DISK_ENCRYPTION_NODE_POOL_GUIDANCE_COPY | ||
| } | ||
| encryptionStatus={encryptionStatus} | ||
| tooltipText={DISK_ENCRYPTION_NODE_POOL_GUIDANCE_COPY} | ||
| /> | ||
| </Box> | ||
| ) : ( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an unrelated change, but something I caught from the mocks. Enterprise clusters don't have the 250 maximum.