-
Notifications
You must be signed in to change notification settings - Fork 374
refactor: [M3-9656] - [Akamai Design System] Label Component #12005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Cloud Manager UI test results🔺 6 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/cloudpulse/edit-user-alert.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts" |
@jaalah-akamai Not sure that I can run it locally, but if you could attach screenshots into "Before/After" section to review, that's will be enough. |
@davyd-akamai Here are some screen shots. As this is still in Draft, I will wait for the Before and After images in the PR description until I can open this up for Review. Current Label and Icon size and placementChanges Introduced in this PRLarge Label with Large Icon on right side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@tzmiivsk-akamai could you take a look as well? |
Hi! @carrillo-erik @davyd-akamai Based on the screenshots, I can see that the text color differs from the tokens I see in Figma. I'd also like to point out that in Figma, the default colors for the icons on the left and right are different (the info icon always uses a secondary color). |
Description 📝
This PR refactors the Label component to the new Akamai Design System.
Changes 🔄
Typography.Label.Bold.L
Typography.Label.Bold.S
left
orright
of the text.Preview 📷
How to test 🧪
Verification steps
labelTooltipIconPosition
andlabelTooltipIconSize
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅