-
Notifications
You must be signed in to change notification settings - Fork 375
refactor: [M3-9748] - Akamai Design System: Checkbox component - Sizes
#12020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-9748] - Akamai Design System: Checkbox component - Sizes
#12020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but Davyd and Tetiana did you want the ripple disabled?
I agree with Davyd's comments. |
@davyd-akamai @tzmiivsk-akamai @jaalah-akamai
I think the |
I think, in this case let's remove the ripple effect, so the label will be aligned with a checkbox. Is it ok @tzmiivsk-akamai ? |
@pmakode-akamai @davyd-akamai @jaalah-akamai
If that’s the reason why the alignment is broken, I’m okay with removing that effect. |
@tzmiivsk-akamai Ah, I see. In that case, we can keep the ripple and just adjust this specific case. @davyd-akamai @tzmiivsk-akamai @jaalah-akamai Could you take a look? |
Thank you! Could you share a preview link one more time, please? I seem to be having trouble accessing Cloud Manager today... |
preview link: https://linode-cloud-pr-12020.website-us-east-1.linodeobjects.com/ |
It’s not just about the table component — the list, dropdown, and paginator will also have smaller checkboxes. Sometimes our data is quite dense, and we have limited space to display it effectively. Also, according to the CDS table guidelines, the entire row should be selectable, not just the checkbox. However, since we’re updating the UI in stages, this behavior will be introduced later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Cloud Manager UI test results🎉 565 passing tests on test run #9 ↗︎
|
Description 📝
We need to ensure that we account for the new sizes of the checkbox in our refactor.
All sizes (sm, md) should be accounted for in the checkboxes - right now they're too big
Changes 🔄
Checkbox
componentsize
prop (which supportssmall
&medium
sizes per Akamai Design System)small
sizeSelectableTableRow
&TransferTable
Target release date 🗓️
N/A
How to test 🧪
Checkbox
component -Sizes
Checkbox
component and its different variants in StorybookSelectableTableRow
in storybookCheckbox
wherever used in CM (in both light and dark modes)sm
size variantAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅