refactor: [M3-8977] - Replace Autocompletes with Select
#12060
+164
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
requested review from
pmakode-akamai and
harsh-akamai
and removed request for
a team
There was a problem hiding this comment.
✅ Create API Token drawer > Expiry field
✅ Create Kubernetes Cluster > Kubernetes version
✅ Firewall Rule Drawer > Protocol, Sources
✅ NodeBalancers Configuration > Protocol, Proxy Protocol, Mode
❗️ Looks like the test failures are related to these changes and are occurring locally as well
hkhalil-akamai
requested review from
jdamore-linode and
pmakode-akamai
and removed request for
a team
Cloud Manager UI test results🎉 567 passing tests on test run #4 ↗︎
|
pmakode-akamai
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
thanks @hkhalil-akamai! Just a couple of ESLint warnings; other than that, it looks good to me ✅
| type DrawerModes, | ||
| type ExtendedRole, | ||
| type ExtendedRoleMap, | ||
| } from '../utilities'; |
There was a problem hiding this comment.
Could we import these types like this: import type { DrawerModes, ExtendedRole, ExtendedRoleMap } from '../utilities'; for consistency and resolve the import order eslint warnings in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Replaces
Autocompletes in favor of the simplerSelectcomponent in the locations identified in the ticket.Some of the instances from the ticket were skipped since those Autocompletes leverage disabling individual options or customer
renderOptionfunctions, which are not currently supported bySelect. See the ticket for more details.The Autocomplete in
RegionTypeFilterwas more complex and was handled in #12018.Changes 🔄
Replace
AutocompletewithSelectin:Preview 📷
How to test 🧪
Verify the instances listed above continue to work as expected. Try selecting between values and submitting each form.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅