Skip to content

fix: [M3-9968] - Input placholder opacity #12208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented May 13, 2025

Description 📝

Small PR to fix the placeholder opacity so we are showing the right color. Right now the placeholder text is barely readable (likely failing most accessibility standards), because of the default opacity applied to it in the MUI styles.

This style change will apply to all text inputs (Textfield, Text area, Autocomplete etc)

Changes 🔄

  • Set placeholder opacity back to 1 to get the proper CDS placeholder color

Preview 📷

Before After
Screen Shot 2025-05-13 at 13 27 04 Screen Shot 2025-05-13 at 13 20 02
Screen Shot 2025-05-13 at 13 32 22 Screen Shot 2025-05-13 at 13 31 34

How to test 🧪

Verification steps

Check placeholder treatment for inputs through the application

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai self-assigned this May 13, 2025
@abailly-akamai abailly-akamai marked this pull request as ready for review May 13, 2025 17:36
@abailly-akamai abailly-akamai requested a review from a team as a code owner May 13, 2025 17:36
@abailly-akamai abailly-akamai requested review from carrillo-erik and harsh-akamai and removed request for a team May 13, 2025 17:36
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 586 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing586 Passing6 Skipped110m 57s

Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abailly-akamai!

@harsh-akamai harsh-akamai added the Add'tl Approval Needed Waiting on another approval! label May 14, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 14, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 16, 2025
@abailly-akamai abailly-akamai merged commit e54e893 into linode:develop May 19, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants