Skip to content

upcoming: [M3-9829] - Refactor AddLinodeDrawer to remove useEffect #12220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
379c543
reinstate old drawer
coliu-akamai May 13, 2025
2d0b468
starting point
coliu-akamai May 13, 2025
db05a47
try handling non-vlan?
coliu-akamai May 13, 2025
6f0f388
figure out how to handle errors
coliu-akamai May 13, 2025
332d57d
something like this??
coliu-akamai May 13, 2025
383292a
another edge case
coliu-akamai May 13, 2025
c96adb6
filtering fixes for now
coliu-akamai May 13, 2025
22a3039
so many edge cases
coliu-akamai May 13, 2025
27b4956
hopefully that's all the edge cases
coliu-akamai May 13, 2025
6790c32
parity
coliu-akamai May 13, 2025
ef5678f
switch back in v2
coliu-akamai May 13, 2025
f77d0f8
copy
coliu-akamai May 13, 2025
324d4c5
how to multi firewall this
coliu-akamai May 14, 2025
adbf7de
yooo?? (cleanup)
coliu-akamai May 14, 2025
931f200
cleanup
coliu-akamai May 14, 2025
2701690
update and cleanup some stuff
coliu-akamai May 14, 2025
c527a95
some more cleanup
coliu-akamai May 14, 2025
0132487
support nodebalancers, add changesets
coliu-akamai May 14, 2025
3212f46
fixes
coliu-akamai May 14, 2025
7573c8a
update function naming
coliu-akamai May 14, 2025
ea39b46
Merge branch 'develop' into m3-9829
coliu-akamai May 16, 2025
d3d620c
additional cleanup?
coliu-akamai May 16, 2025
a32ccff
move show more firewalls to this pr instead
coliu-akamai May 16, 2025
fcd202a
Merge branch 'develop' into m3-9829
coliu-akamai May 27, 2025
6e785da
Merge branch 'develop' into m3-9829
coliu-akamai May 29, 2025
370d52e
begin removing support for multi firewalls
coliu-akamai May 29, 2025
8d50235
continue removing functionality
coliu-akamai May 29, 2025
b045599
small preference updates
coliu-akamai May 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Refactor AddLinodeDrawer to remove useEffect when filtering interface devices ([#12220](https://github.com/linode/manager/pull/12220))
29 changes: 19 additions & 10 deletions packages/manager/src/factories/firewalls.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import {
type Firewall,
type FirewallDevice,
type FirewallDeviceEntityType,
type FirewallRules,
type FirewallRuleType,
type FirewallSettings,
type FirewallTemplate,
type FirewallTemplateRules,
} from '@linode/api-v4/lib/firewalls/types';
import { Factory } from '@linode/utilities';

import type {
Firewall,
FirewallDevice,
FirewallDeviceEntityType,
FirewallRules,
FirewallRuleType,
FirewallSettings,
FirewallTemplate,
FirewallTemplateRules,
} from '@linode/api-v4/lib/firewalls/types';
import type { FirewallDeviceEntity } from '@linode/api-v4/lib/firewalls/types';

export const firewallRuleFactory = Factory.Sync.makeFactory<FirewallRuleType>({
action: 'DROP',
Expand Down Expand Up @@ -58,6 +59,14 @@ export const firewallFactory = Factory.Sync.makeFactory<Firewall>({
updated: '2020-01-01 00:00:00',
});

export const firewallEntityfactory =
Factory.Sync.makeFactory<FirewallDeviceEntity>({
id: 1,
label: 'my-linode',
type: 'linode' as FirewallDeviceEntityType,
url: '/test',
});

export const firewallDeviceFactory = Factory.Sync.makeFactory<FirewallDevice>({
created: '2020-01-01',
entity: {
Expand Down
Loading