-
Notifications
You must be signed in to change notification settings - Fork 379
refactor: [M3-9384] - Move Quotas queries #12221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…red `queries` package
…ery keys and hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed queries still work as expected
thanks Chandra! approving pending unit test fix
packages/manager/.changeset/pr-12221-tech-stories-1747257942556.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Connie Liu <[email protected]>
…6.md Co-authored-by: Connie Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move the query keys definition (quotaQueries
) into a new file called keys.ts in order to follow the directory structure in the epic. See here for an example: #11949 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hkhalil-akamai updated accordingly - e5756f0
packages/manager/src/features/Account/Quotas/QuotasTable.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Hussain Khalil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpathipa! Tests are passing locally.
Cloud Manager UI test results🎉 605 passing tests on test run #12 ↗︎
|
Description 📝
Migrates Quotas-related queries, as well as all dependencies, under the @linode/queries package.
Changes 🔄
Quotas/
directory in the@linode/queries
package with the following structure:packages/manager
.Target release date 🗓️
5/20
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅