Skip to content

refactor: [M3-9384] - Move Quotas queries #12221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 21, 2025
Merged

Conversation

cpathipa
Copy link
Contributor

Description 📝

Migrates Quotas-related queries, as well as all dependencies, under the @linode/queries package.

Changes 🔄

  • Creates new Quotas/ directory in the @linode/queries package with the following structure:
images/
|__ index.ts
|__ images.ts
  • Updates import paths throughout packages/manager.

Target release date 🗓️

5/20

How to test 🧪

  • Rely on e2e tests and CI pipeline to ensure changes do not break the application.
  • No changes to the UI as a result of this PR.

Verification steps

  • Verify that the Images feature works as expected.
  • Verify that other major flows continue to work as expected.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@cpathipa cpathipa requested a review from a team as a code owner May 14, 2025 21:24
@cpathipa cpathipa requested review from hkhalil-akamai and coliu-akamai and removed request for a team May 14, 2025 21:24
@cpathipa cpathipa self-assigned this May 14, 2025
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed queries still work as expected

thanks Chandra! approving pending unit test fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the query keys definition (quotaQueries) into a new file called keys.ts in order to follow the directory structure in the epic. See here for an example: #11949 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hkhalil-akamai updated accordingly - e5756f0

@cpathipa cpathipa requested a review from hkhalil-akamai May 20, 2025 18:01
@cpathipa cpathipa requested a review from hkhalil-akamai May 20, 2025 21:33
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpathipa! Tests are passing locally.

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 21, 2025
@hkhalil-akamai hkhalil-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 21, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 605 passing tests on test run #12 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing605 Passing4 Skipped113m 39s

@cpathipa cpathipa merged commit 8ab8654 into linode:develop May 21, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants